-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.kubernetes): allow fetching kublet metrics remotely #12301
Conversation
576d2a9
to
c57d2f4
Compare
c57d2f4
to
ca61dc5
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 🥳 This pull request decreases the Telegraf binary size by -2.36 % for linux amd64 (new size: 154.4 MB, nightly size 158.1 MB) 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I've added some questions due to my lack of knowledge that I am hoping you can help educate me.
Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for walking me through those changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @redbaron for your contribution!
Required for all PRs
There is no reason to run daemonset to access kubelets, it can be done remotely. This PR makes
inputs.kubernetes
plugin to fetch node information from all the nodes when URL is set to empty value. Example config:Tested with following kubernetes cluster role: