Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add User-Agent header to http_response input plugin #12324

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

CHTJonas
Copy link
Contributor

@CHTJonas CHTJonas commented Dec 2, 2022

If merged, this PR would auto-set the HTTP User-Agent header for outgoing requests from the http_response input plugin according to industry best-practice, rather than relying on the default Go-http-client/1.1 value. Additionally, it is backwards compatible as we respect any UA header that the user may have configured for themselves and do not override it.

  • Updated associated README.md (nothing to update).
  • Wrote appropriate unit tests.
  • Pull request title or commits are in conventional commit format

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Dec 2, 2022
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Dec 2, 2022

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 2, 2022
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks beautiful. Thanks @CHTJonas!

@srebhan srebhan merged commit 1a6c363 into influxdata:master Dec 5, 2022
@CHTJonas CHTJonas deleted the patch-1 branch December 7, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants