-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.smart): Add additional SMART metrics that indicate/predict device failure #12329
Conversation
I closed and re-opened the PR to get CI to kickoff |
Thanks for the PR, looks like the tests will need an update for these additional fields. |
Added. Thanks. |
I did file an issue with CircleCI about the error message:
|
I heard back from CircleCI, namely, it sounds like this shows up when you have an account with CircleCI and either you are logged out if you use a username/password or if you have a GitHub OAuth login, need to disconnect and reconnect your account. |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Nice work @r4um! Thanks for your contribution!
Additional critical SMART metrics that are helpful in indicating/predicting device failure. From https://en.wikipedia.org/wiki/Self-Monitoring,_Analysis_and_Reporting_Technology#Known_ATA_S.M.A.R.T._attributes