Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.smart): Add additional SMART metrics that indicate/predict device failure #12329

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

r4um
Copy link
Contributor

@r4um r4um commented Dec 5, 2022

Additional critical SMART metrics that are helpful in indicating/predicting device failure. From https://en.wikipedia.org/wiki/Self-Monitoring,_Analysis_and_Reporting_Technology#Known_ATA_S.M.A.R.T._attributes

@telegraf-tiger telegraf-tiger bot added area/smart feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 5, 2022
@powersj powersj closed this Dec 5, 2022
@powersj powersj reopened this Dec 5, 2022
@powersj
Copy link
Contributor

powersj commented Dec 5, 2022

I closed and re-opened the PR to get CI to kickoff

@powersj
Copy link
Contributor

powersj commented Dec 5, 2022

Thanks for the PR, looks like the tests will need an update for these additional fields.

@powersj powersj added the waiting for response waiting for response from contributor label Dec 5, 2022
@r4um
Copy link
Contributor Author

r4um commented Dec 5, 2022

Thanks for the PR, looks like the tests will need an update for these additional fields.

Added. Thanks.

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Dec 5, 2022
@powersj
Copy link
Contributor

powersj commented Dec 5, 2022

I did file an issue with CircleCI about the error message:

CircleCI Pipeline — Could not find a usable config.yml, you may have revoked the CircleCI OAuth app.

@powersj powersj closed this Dec 5, 2022
@powersj powersj reopened this Dec 5, 2022
@powersj
Copy link
Contributor

powersj commented Dec 9, 2022

CircleCI Pipeline — Could not find a usable config.yml, you may have revoked the CircleCI OAuth app.

I heard back from CircleCI, namely, it sounds like this shows up when you have an account with CircleCI and either you are logged out if you use a username/password or if you have a GitHub OAuth login, need to disconnect and reconnect your account.

@powersj powersj closed this Dec 9, 2022
@powersj powersj reopened this Dec 9, 2022
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Dec 9, 2022

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 9, 2022
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work @r4um! Thanks for your contribution!

@srebhan srebhan merged commit 4161651 into influxdata:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/smart feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants