Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.cgroups): dont abort on first error, stop error message spam #12342

Merged

Conversation

mhoffm-aiven
Copy link
Contributor

Required for all PRs

resolves #12338

Added a small lookup table for files that we already reported errors on so that we dont report them on every Gather round. Also fixed a bug where a formatting error would lead to subsequent files not being collected.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 6, 2022
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this issue @mhoffm-aiven! I do have some minor comments in the code...

plugins/inputs/cgroup/cgroup_test.go Outdated Show resolved Hide resolved
plugins/inputs/cgroup/cgroup.go Outdated Show resolved Hide resolved
plugins/inputs/cgroup/cgroup_test.go Outdated Show resolved Hide resolved
plugins/inputs/cgroup/cgroup_test.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Dec 6, 2022
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for also migrating the existing tests @mhoffm-aiven!

@srebhan srebhan added area/system ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Dec 7, 2022
@srebhan srebhan assigned powersj and unassigned srebhan Dec 7, 2022
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@powersj powersj merged commit d7d1f8b into influxdata:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/system feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs, cgroup: spams errors and exits collection too early on unknown file formats
3 participants