Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.cisco_telemetry_mdt): Include delete field #12345

Merged
merged 22 commits into from
Jan 25, 2023
Merged

feat(inputs.cisco_telemetry_mdt): Include delete field #12345

merged 22 commits into from
Jan 25, 2023

Conversation

severindellsperger
Copy link
Contributor

Required for all PRs

resolves #12286

Implement the logic to include the delete field as discussed in #12286 to support Event-Driven Telemetry (EDT).

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 6, 2022
srebhan
srebhan reviewed Dec 8, 2022
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @severindellsperger for your patience and the great work! I have a few minor comments in the code.
However, I want to encourage you to submit your newly created proto-go-code as a PR to the original repository at github.com/cisco-ie/nx-telemetry-proto so we (on the Telegraf side) do not have the burden to go through those dependency changes every time a new feature is added. What do you think?

go.mod Outdated Show resolved Hide resolved
plugins/inputs/cisco_telemetry_mdt/sample.conf Outdated Show resolved Hide resolved
plugins/inputs/cisco_telemetry_mdt/sample.conf Outdated Show resolved Hide resolved
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go Outdated Show resolved Hide resolved
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go Outdated Show resolved Hide resolved
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go Outdated Show resolved Hide resolved
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go Outdated Show resolved Hide resolved
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt_test.go Show resolved Hide resolved
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt_test.go Outdated Show resolved Hide resolved
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt_test.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Dec 8, 2022
@powersj powersj closed this Dec 13, 2022
@powersj powersj reopened this Dec 13, 2022
srebhan
srebhan approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your explanations @severindellsperger! I have two cosmetic suggestions for the sample.conf but nothing to hold up this PR.

@powersj what do you think about the dependency? Should we merge as is and adapt later once there is an "official Cisco release" or should we go with the other repo?

plugins/inputs/cisco_telemetry_mdt/sample.conf Outdated Show resolved Hide resolved
plugins/inputs/cisco_telemetry_mdt/sample.conf Show resolved Hide resolved
@srebhan srebhan assigned powersj and unassigned srebhan Jan 10, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 10, 2023
@powersj
Copy link
Contributor

powersj commented Jan 10, 2023

@severindellsperger, did you ask Cisco to host the repo publicly? Have they acknowledged the request?

@severindellsperger
Copy link
Contributor Author

@severindellsperger, did you ask Cisco to host the repo publicly? Have they acknowledged the request?
I have no answer yet. I have a meeting next week and will discuss it then.

@severindellsperger
Copy link
Contributor Author

The PR is out: cisco-ie/nx-telemetry-proto#2
Let's hope it will be merged soon so that we can adjust.

@powersj
Copy link
Contributor

powersj commented Jan 17, 2023

The PR is out: cisco-ie/nx-telemetry-proto#2 Let's hope it will be merged soon so that we can adjust.

Looks like that got landed. Thank you for doing that work!

@severindellsperger
Copy link
Contributor Author

@powersj @srebhan I made the necessary changes. I think the PR is now ready for the final review.

srebhan
srebhan reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small improvement and please address my comments for sample.conf.

plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go Outdated Show resolved Hide resolved
@srebhan
Copy link
Contributor

srebhan commented Jan 18, 2023

Oh and you should run make docs...

severindellsperger and others added 11 commits January 19, 2023 11:23
severindellsperger and others added 10 commits January 19, 2023 11:25
@severindellsperger
change import order + optimize telemetry message handling
2da0fe4
@severindellsperger @srebhan
Update plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt_test.go
9d55f8d 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@severindellsperger
refactor tests
ead6d01
@severindellsperger
Change import path back to nx-telemetry-proto repo
c787528
@severindellsperger
run 'go mod tidy'
4a786b8
@severindellsperger @srebhan
Update plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go
bb2e435 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@severindellsperger @srebhan
Update plugins/inputs/cisco_telemetry_mdt/sample.conf
b599fbe 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@severindellsperger
add trailing newline in sample.conf
69eeee5
@severindellsperger @srebhan
Update plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt_test.go
c7e2283 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@severindellsperger
add docs and remove unnecessart imports
30aafef
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

srebhan
srebhan approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for keeping this going @severindellsperger!

powersj
powersj approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thank you severindellsperger for driving this here and with cisco!

@powersj powersj merged commit 607bfdb into influxdata:master Jan 25, 2023
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@powersj powersj

Labels
area/cisco feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.26.0
3 participants
@severindellsperger @powersj @srebhan