Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump github.com/gosnmp/gosnmp from 1.34.0 to 1.35.0 #12355

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Dec 7, 2022

replaces #11370

With the new version a stricter check for the msgAuthoritativeEngineID field is implemented (see gosnmp code). This made the tests fro SNMPv3 traps fail in #11370.

To circumvent a missing call to OnNewTrap this PR makes sure the engine-ID is between 5 and 32 characters to pass the tests.

@srebhan srebhan added area/snmp dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Dec 7, 2022
@srebhan srebhan assigned srebhan and unassigned powersj Dec 8, 2022
@srebhan srebhan merged commit 8d78c5f into influxdata:master Dec 8, 2022
@srebhan srebhan deleted the snmp_pr_11370 branch December 8, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/snmp chore dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants