Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agent): Deprecate active usage of netsnmp translator #12358

Merged
merged 2 commits into from
Dec 8, 2022
Merged

feat(agent): Deprecate active usage of netsnmp translator #12358

merged 2 commits into from
Dec 8, 2022

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Dec 8, 2022

Required for all PRs

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Dec 8, 2022
@Hipska Hipska added area/snmp area/agent feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Dec 8, 2022
srebhan
srebhan approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @Hipska!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 8, 2022
@Hipska
Copy link
Contributor Author

Hipska commented Dec 8, 2022

!retry-failed

@powersj powersj merged commit c883673 into influxdata:master Dec 8, 2022
@Hipska Hipska deleted the feat/agent/deprecate_translator_netsnmp branch December 8, 2022 14:30
@matthijskooijman matthijskooijman mentioned this pull request Feb 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@powersj powersj

Labels
area/agent area/snmp feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hipska @powersj @srebhan