Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.modbus): Fix default value of transmission mode #12367

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Dec 9, 2022

resolves #11837

Currently, the transmission_mode's default value in the config does not match the actual behavior as pointed out in #11837. The difficulty is that we have a different default for TCP-based controllers ("TCP") and serial-controllers ("RTU"). This PR introduces a new "auto" value to capture this different behavior and makes it the new default.

This PR does not change the actual behavior of the plugin but makes the configuration behavior more clear.

@telegraf-tiger telegraf-tiger bot added area/modbus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 9, 2022
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 9, 2022
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Dec 9, 2022

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@powersj powersj merged commit 7df9748 into influxdata:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modbus default values do not match example config
2 participants