-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.sqlserver): More precise version check #12384
Conversation
Some queries do not work with 2008R2 RTM, but they need at least SP2
@Trovalo can you please take a look!? |
The PR is ok, @srebhan do we also need to create an issue or having just the PR is fine? |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
@Trovalo I think the text in the PR is clear enough to not requiring an issue, what do you think @powersj? Regarding the "Semantic PR..." error, it comes from the fact that this PR has only one commit, so the commit also needs to adhere to the semantic PR standards... We can fix this manually on this PR, but please keep this in mind for future PRs @spaghettidba! |
@spaghettidba can you please try to rebase this PR on the latest master to (hopefully) get CircleCI to retry?!? |
Sorry, I have no idea how to do that. My GitHub abilities are extremely limited. |
Running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @spaghettidba for the fix! Given that this seems not to touch any go-code, I'm also find with just merging it as-is. @powersj what do you think?
(cherry picked from commit d476018)
Some queries do not work with 2008R2 RTM, but they need at least SP2
Queries changed:
sqlServerProperties
sqlServerVolumeSpace
Updated associated README.md.
Wrote appropriate unit tests.
Pull request title or commits are in conventional commit format