Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.sqlserver): SqlRequests include sleeping sessions with open transactions #12386

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

spaghettidba
Copy link
Contributor

example: Fixed an off by one error in counter variable in type FooBar.

SqlRequests did not include sleeping sessions with open transactions. This can make troubleshooting slightly problematic in some cases, where you see a blocked SPID but you don't see how long the blocking session has been sleeping. This fix will allow tracking sleeping sessions that keep transactions open.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Dec 13, 2022
@spaghettidba spaghettidba changed the title fix: SqlRequests include sleeping sessions with open transactions fix(inputs.sqlserver): SqlRequests include sleeping sessions with open transactions Dec 13, 2022
@telegraf-tiger
Copy link
Contributor

@Trovalo Trovalo self-requested a review December 13, 2022 12:44
@Trovalo
Copy link
Collaborator

Trovalo commented Dec 13, 2022

makes sense to me, but I'd like to have also the opinion of @dimitri-furman as this will be implemented also for the Azure part

@Trovalo Trovalo added area/sqlserver plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 13, 2022
Copy link

@dimitri-furman dimitri-furman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful change for all flavors of SQL.

Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @spaghettidba!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 16, 2022
@powersj powersj merged commit 82555d3 into influxdata:master Dec 16, 2022
srebhan pushed a commit that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sqlserver fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants