Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.sqlserver): Add SPID filter for sqlserverqueries.go #12387

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix(inputs.sqlserver): Add SPID filter for sqlserverqueries.go #12387

merged 1 commit into from
Dec 16, 2022

Conversation

spaghettidba
Copy link
Contributor

This filter has been set on all other source files (azureSqlDB and azureSqlMI) but not on the on-prem version

resolves #11709 also for on-prem

@spaghettidba
fix: Added own SPID filter to sqlserverqueries.go
3ace226 
This filter has been set on all other source files (azureSqlDB and azureSqlMI) but not on the on-prem version
@spaghettidba spaghettidba changed the title fix: Added own SPID filter to sqlserverqueries.go fix(inputs.sqlserver): Added own SPID filter to sqlserverqueries.go Dec 13, 2022
@Trovalo Trovalo self-requested a review December 13, 2022 12:45
@Trovalo
Copy link
Collaborator

Trovalo commented Dec 13, 2022

This filter was still missing for the on-prem queries as #11709 changed sqlqueriesV2.go (which are "obsolete") instead of sqlserverqueries.go

srebhan
srebhan approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for catching this @spaghettidba!

@srebhan srebhan added fix pr to fix corresponding bug area/sqlserver ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 16, 2022
@srebhan srebhan changed the title fix(inputs.sqlserver): Added own SPID filter to sqlserverqueries.go fix(inputs.sqlserver): Addd own SPID filter to sqlserverqueries.go Dec 16, 2022
@srebhan srebhan changed the title fix(inputs.sqlserver): Addd own SPID filter to sqlserverqueries.go fix(inputs.sqlserver): Add SPID filter for sqlserverqueries.go Dec 16, 2022
@powersj powersj merged commit 37db046 into influxdata:master Dec 16, 2022
srebhan pushed a commit that referenced this pull request Jan 30, 2023
@spaghettidba
fix: Added own SPID filter to sqlserverqueries.go (#12387)
05940d8 
This filter has been set on all other source files (azureSqlDB and azureSqlMI) but not on the on-prem version

(cherry picked from commit 37db046)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@Trovalo Trovalo Trovalo approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@powersj powersj

Labels
area/sqlserver fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spaghettidba @Trovalo @powersj @srebhan