Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.sqlserver): Get Database Pages performance counter #12400

Merged
merged 7 commits into from
Jan 9, 2023

Conversation

goswamisandeep
Copy link
Contributor

Required for all PRs

resolves #

@telegraf-tiger telegraf-tiger bot added area/sqlserver feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 14, 2022
@goswamisandeep
Copy link
Contributor Author

As per the blog https://learn.microsoft.com/en-us/sql/relational-databases/performance-monitor/monitor-memory-usage?view=sql-server-ver16

SQL Server: Buffer Manager: Database Pages

This counter indicates the number of pages in the buffer pool with database content. Does not include other nonbuffer pool memory within the SQL Server process. Query this counter using the sys.dm_os_performance_counters dynamic management view.

@telegraf-tiger
Copy link
Contributor

@srebhan srebhan self-assigned this Dec 15, 2022
@srebhan srebhan requested a review from Trovalo December 15, 2022 09:51
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, but I again want to hear @Trovalo's opinion.

@Trovalo
Copy link
Collaborator

Trovalo commented Dec 15, 2022

I've nothing against it but I honestly don't see it as a useful counter. If the aim is to check if the server is under memory pressure it's better to check the Page Life Expectancy.

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 19, 2022
@powersj powersj merged commit aa2b694 into influxdata:master Jan 9, 2023
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sqlserver feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants