Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secretstores): Cleanup #12401

Merged
merged 6 commits into from
Dec 15, 2022
Merged

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Dec 14, 2022

This PR adds a helper to check for uninitialized and/or empty secrets without the need to decode them. It also removes the duplicate "secret store plugins" section (and plugins) in the generated sample config.
Furthermore, the PR addresses the comments of @Hipska in #11232, e.g. making the secret-path a mandatory option for the JOSE store.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Dec 14, 2022
@srebhan srebhan added plugin/secretstores ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Dec 14, 2022
@srebhan srebhan changed the title fix(secretstores): Fix duplicate printing and check for empty secrets fix(secretstores): Cleanup Dec 15, 2022
@telegraf-tiger
Copy link
Contributor

@powersj powersj merged commit 9f55bc6 into influxdata:master Dec 15, 2022
srebhan added a commit that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/secretstores ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants