Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.x509_cert): Fix off-by-one when adding intermediates #12404

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Dec 15, 2022

resolves #12402

When adding intermediate certificates we always omit the first certificate, thus we need to add +1 when comparing the inputs as index 0 of the intermediates is actually index 1 in the certs.

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 15, 2022
@srebhan srebhan added the regression something that used to work, but is now broken label Dec 15, 2022
@srebhan srebhan self-assigned this Dec 15, 2022
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan assigned powersj and unassigned powersj and srebhan Dec 15, 2022
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 15, 2022
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah off by one errors, nice :)

@powersj powersj merged commit d9820bf into influxdata:master Dec 15, 2022
srebhan added a commit that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. regression something that used to work, but is now broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x509_cert plugin broken in release 1.25.0
2 participants