Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.modbus): Add workaround to enforce reads from zero for coil registers #12408

Merged
merged 8 commits into from
Jan 9, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Dec 16, 2022

resolves #8905

This PR allows to enforce reading coil-registers starting at zero which is required for some devices (see issue #8905). This replaces a workaround to define all fields between the register you want to read (e.g. 1000) and zero with the omit flag being set to true.

@telegraf-tiger telegraf-tiger bot added area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 16, 2022
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 16, 2022
Co-authored-by: Joshua Powers <powersj@fastmail.com>
@srebhan srebhan requested a review from powersj January 9, 2023 09:18
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, obviously it would have been nice to get the reporter to confirm it fixes things though.

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jan 9, 2023

@powersj powersj merged commit 150f0cd into influxdata:master Jan 9, 2023
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
@srebhan srebhan mentioned this pull request Jun 27, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[inputs.modbus] read multiple coils with higher address gives wrong result
2 participants