-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(json_v2): In case of invalid json, log messsage to debug log #12440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the log only says "Error in plugin: invalid JSON provided, unable to parse". Most other error cases in this parser already emit the message to debug log, use the same pattern for this error case as well
powersj
reviewed
Jan 3, 2023
as per the review comment
powersj
reviewed
Jan 9, 2023
powersj
approved these changes
Jan 9, 2023
powersj
added
the
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
label
Jan 9, 2023
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this useful addition @vvvrrooomm!
srebhan
added
area/json
json and json_v2 parser/serialiser related
plugin/parser
1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins
labels
Jan 12, 2023
srebhan
pushed a commit
that referenced
this pull request
Jan 30, 2023
) (cherry picked from commit 82ec689)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/json
json and json_v2 parser/serialiser related
fix
pr to fix corresponding bug
plugin/parser
1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the log only says "Error in plugin: invalid JSON provided, unable to parse".
Most other error cases in this parser already emit the message to debug log, use the same pattern for this error case as well
Required for all PRs
resolves #