Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json_v2): In case of invalid json, log messsage to debug log #12440

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

vvvrrooomm
Copy link
Contributor

Currently the log only says "Error in plugin: invalid JSON provided, unable to parse".
Most other error cases in this parser already emit the message to debug log, use the same pattern for this error case as well

Required for all PRs

  • [x ] Updated associated README.md.
  • [ x] Wrote appropriate unit tests.
  • [ x] Pull request title or commits are in conventional commit format

resolves #

Currently the log only says "Error in plugin: invalid JSON provided, unable to parse".
Most other error cases in this parser already emit the message to debug log, use the same pattern for this error case as well
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Dec 27, 2022
as per the review comment
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 9, 2023
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this useful addition @vvvrrooomm!

@srebhan srebhan merged commit 82ec689 into influxdata:master Jan 12, 2023
@srebhan srebhan added area/json json and json_v2 parser/serialiser related plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins labels Jan 12, 2023
@vvvrrooomm vvvrrooomm deleted the patch-1 branch January 14, 2023 10:52
srebhan pushed a commit that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/json json and json_v2 parser/serialiser related fix pr to fix corresponding bug plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants