fix(agent): only set default snmp after reading all configs #12457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the default snmp reader is set after reading every file. This can lead to unnecessary deprecation messages that do not make sense to the user. Instead, only set the default, deprecated snmp reader after all files are read in. This way the user is only notified of the deprecation if they actually choose to use that value in their config. fixes: influxdata#12454
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
Hipska
approved these changes
Jan 9, 2023
Hipska
added
the
ready for final review
|
What if the first loaded file has it set? Will you get the warning for each file after? |
srebhan
pushed a commit
that referenced
this pull request
Jan 30, 2023
(cherry picked from commit 2604fb6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the default snmp reader is set after reading every file. This can lead to unnecessary deprecation messages that do not make sense to the user. Instead, only set the default, deprecated snmp reader after all files are read in. This way the user is only notified of the deprecation if they actually choose to use that value in their config.
fixes: #12454