Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.bond): Reset slave stats for each interface #12462

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix(inputs.bond): Reset slave stats for each interface #12462

merged 1 commit into from
Feb 16, 2023

Conversation

felixhuettner
Copy link
Contributor

Previously the status value has been initialized to 0 only when starting to parse a whole bond. If any single interface in the bond is up the status is set to 1 for all following interfaces (even if they are down).

To fix this we reset all collected fields after each interface is finished. This should also resolve the unlikely case that some interfaces have different fields than others.

Required for all PRs

CLA signing is still in progress

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jan 5, 2023

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@felixhuettner
fix(bond): reset slave stats for each interface
f1cd595 
Previously the `status` value has been initialized to 0 only when
starting to parse a whole bond. If any single interface in the bond is
up the `status` is set to 1 for all following interfaces (even if they
are down).

To fix this we reset all collected fields after each interface is
finished. This should also resolve the unlikely case that some
interfaces have different fields than others.
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jan 5, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

powersj
powersj approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR and test case. I think this makes sense.

@powersj
Copy link
Contributor

powersj commented Jan 5, 2023

let us know once you sign the CLA please!

@powersj
Copy link
Contributor

powersj commented Jan 26, 2023

Hi @felixhuettner - wanted to checking and see if you had an update on signing the CLA? Thanks

@powersj powersj added the waiting for response waiting for response from contributor label Jan 26, 2023
@powersj powersj self-assigned this Jan 26, 2023
@felixhuettner
Copy link
Contributor Author

Hi @felixhuettner - wanted to checking and see if you had an update on signing the CLA? Thanks

sorry, still in our signing process unfortunately

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Jan 27, 2023
@felixhuettner
Copy link
Contributor Author

CCLA is finally send out and i signed the individual one.
Lets see if this already works

!signed-cla

@felixhuettner
Copy link
Contributor Author

!signed-cla

@felixhuettner
Copy link
Contributor Author

@powersj CLA is finally signed

powersj
powersj approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving again but have one question in line and will have Sven give this a look over as well.

plugins/inputs/bond/bond.go Show resolved Hide resolved
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 15, 2023
@powersj powersj assigned srebhan and unassigned srebhan and powersj Feb 15, 2023
srebhan
srebhan approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice fix and the test @felixhuettner!

@srebhan srebhan changed the title fix bond: reset slave stats for each interface fix(inputs.bond): Reset slave stats for each interface Feb 16, 2023
@srebhan srebhan added area/network New plugins or feature relating to Network Monitoring plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. fix pr to fix corresponding bug and removed ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Feb 16, 2023
@srebhan srebhan merged commit 5ac9494 into influxdata:master Feb 16, 2023
powersj pushed a commit that referenced this pull request Feb 27, 2023
@felixhuettner @powersj
fix(inputs.bond): Reset slave stats for each interface (#12462)
99f825e 
(cherry picked from commit 5ac9494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/network New plugins or feature relating to Network Monitoring fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixhuettner @powersj @srebhan