Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add snow parameter to OpenWeathermap input plugin #12466

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

nberardi
Copy link
Contributor

@nberardi nberardi commented Jan 8, 2023

Required for all PRs

Add support for snow field in OpenWeatherMap input plugin

New fields: snow

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jan 8, 2023

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jan 8, 2023
@nberardi
Copy link
Contributor Author

nberardi commented Jan 8, 2023

Apologies, I forgot to sign the CLA. It is now done.

@Hipska Hipska added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Jan 9, 2023
@Hipska
Copy link
Contributor

Hipska commented Jan 9, 2023

You also need to update all other tests to include a zero snow field.

@powersj powersj added the waiting for response waiting for response from contributor label Jan 9, 2023
@srebhan
Copy link
Contributor

srebhan commented Jan 12, 2023

!signed-cla

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Jan 12, 2023
@Hipska Hipska added the waiting for response waiting for response from contributor label Jan 12, 2023
@nberardi
Copy link
Contributor Author

You also need to update all other tests to include a zero snow field.

Those aren’t required because the snow property isn’t returned if the field is zero. Same with the rain forecast.

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Jan 12, 2023
@nberardi
Copy link
Contributor Author

63F69CC4-0415-4243-A335-5AF132A1861B

I signed the CLA again.

@Hipska
Copy link
Contributor

Hipska commented Jan 12, 2023

You also need to update all other tests to include a zero snow field.

Those aren’t required because the snow property isn’t returned if the field is zero. Same with the rain forecast.

Anyway, the tests are now failing. They need to be fixed in order to get this merged.

I signed the CLA again.

Correct, and by running that command, the CLA test is re-run and now succeeds.

@nberardi
Copy link
Contributor Author

nberardi commented Jan 12, 2023

Anyway, the tests are now failing. They need to be fixed in order to get this merged.

I will correct the tests. I didn’t see them failing previously when I ran them on my box. I probably missed the commit.

@nberardi
Copy link
Contributor Author

The test server on windows appears to be failing. Hopefully that won’t be held against me. 😀

@telegraf-tiger
Copy link
Contributor

@Hipska Hipska added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 13, 2023
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution @nberardi!

@srebhan srebhan merged commit aa4e01a into influxdata:master Jan 18, 2023
@nberardi nberardi deleted the patch-1 branch February 8, 2023 13:54
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants