-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add snow parameter to OpenWeathermap input plugin #12466
Conversation
Thanks so much for the pull request! |
Apologies, I forgot to sign the CLA. It is now done. |
You also need to update all other tests to include a zero snow field. |
!signed-cla |
Those aren’t required because the snow property isn’t returned if the field is zero. Same with the rain forecast. |
Anyway, the tests are now failing. They need to be fixed in order to get this merged.
Correct, and by running that command, the CLA test is re-run and now succeeds. |
I will correct the tests. I didn’t see them failing previously when I ran them on my box. I probably missed the commit. |
The test server on windows appears to be failing. Hopefully that won’t be held against me. 😀 |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your contribution @nberardi!
Required for all PRs
Add support for snow field in OpenWeatherMap input plugin
New fields: snow