fix(secretstores): Fix handling of TOML strings #12490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #12488
The current TOML parsing for secrets is not compatible with the was strings were parsed before. As a consequence e.g. escaped constant string secrets (as in #12488) will be returned as if they were literals, breaking existing configurations.
This PR fixes the TOML parsing and ensures that secrets are parsed exactly as if you would specify a string by adding corresponding tests.