Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secretstores): Fix handling of TOML strings #12490

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Jan 11, 2023

resolves #12488

The current TOML parsing for secrets is not compatible with the was strings were parsed before. As a consequence e.g. escaped constant string secrets (as in #12488) will be returned as if they were literals, breaking existing configurations.

This PR fixes the TOML parsing and ensures that secrets are parsed exactly as if you would specify a string by adding corresponding tests.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jan 11, 2023
@srebhan srebhan added regression something that used to work, but is now broken plugin/secretstores labels Jan 11, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 11, 2023
@powersj powersj merged commit a3e4a14 into influxdata:master Jan 11, 2023
srebhan added a commit that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/secretstores ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. regression something that used to work, but is now broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlserver plugin - secret store issue
2 participants