Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.redfish): add power control metric #12496

Merged
merged 3 commits into from
Jan 18, 2023
Merged

feat(inputs.redfish): add power control metric #12496

merged 3 commits into from
Jan 18, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jan 11, 2023

This adds the ability to parse the power control data. This includes values like the power consumed watts as well as other metrics.

fixes: #9575

@telegraf-tiger telegraf-tiger bot added area/redfish feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 11, 2023
@powersj powersj mentioned this pull request Jan 11, 2023
Closed
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 13, 2023
@powersj powersj marked this pull request as ready for review January 13, 2023 01:35
srebhan
srebhan reviewed Jan 13, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature @powersj. Just two comments regarding the initialization of fields and tags.

plugins/inputs/redfish/redfish.go Outdated Show resolved Hide resolved
plugins/inputs/redfish/redfish.go Outdated Show resolved Hide resolved
powersj and others added 3 commits January 13, 2023 08:04
@powersj
feat(inputs.redfish): add power control metric
5e9492e 
This adds the ability to parse the power control data. This includes
values like the power consumed watts as well as other metrics.

fixes: influxdata#9575
@powersj @srebhan
Update plugins/inputs/redfish/redfish.go
345cf56 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@powersj
direct init fields
92827dd
@powersj
Copy link
Contributor Author

powersj commented Jan 13, 2023

@srebhan ready for a 2nd - thanks!

@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

srebhan
srebhan approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Thanks for the update and your effort @powersj!

@srebhan srebhan merged commit 5cc626f into influxdata:master Jan 18, 2023
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.26.0
Development

Successfully merging this pull request may close these issues.

Add loading PowerConsumedWatts from redfish input plugin (Dell server)
2 participants
@powersj @srebhan