Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secretstores): Convert (most) output plugins #12497

Merged
merged 23 commits into from
Jan 25, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Jan 11, 2023

resolves #12484

This PR converts most output plugins to be able to use secrets and thus secret-store(s) for their credentials such as username and password and/or tokens. This leaves us with outputs.health and outputs.prometheus_client as those are listening for connections and are thus receiving credentials compared to all others which send credentials. The two mentioned plugins will be converted later.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jan 11, 2023
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan added plugin/secretstores ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jan 12, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@powersj powersj merged commit f5c2c4a into influxdata:master Jan 25, 2023
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/secretstores ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add "secrets" support for influxdb_v2 output
3 participants