-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.icinga2): Support collecting hosts,services and endpoint metrics #12506
Conversation
7a2b35f
to
f67a024
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to put a PR. I think the big things are 1) we have a deprecation framework that you should use and 2) the default values need to be consistent and documented.
Once you make some updates we can give it a more complete review
094cf3d
to
89845d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up, just some final small items.
56788b9
to
4a2d80c
Compare
@powersj Thanks, let me know if you need more changes. The CI failures should be unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks quite nice @deric, however I do have a few comments. Can you please take a look?
6cf407b
to
4b01367
Compare
e1f3200
to
af1ff52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deric I do have two cosmetic suggestions/comments. Let me know if you want to apply those. Otherwise I will merge in about 7h...
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your contribution @deric!
This PR adds possibility to collect both
hosts
andservices
metrics from Icinga 2 API at the same time. Furthermore it adds possibility to parse Icinga2 endpoint metrics. These metrics are crucial for evaluating bottlenecks in Icinga2 setup.Currently only partial stats endpoints support:
/v1/status/ApiListener
/v1/status/CIB
/v1/status/IdoMysqlConnection
/v1/status/IdoPgsqlConnection
Test output: