-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.gnmi): Handle both new-style tag_subscription
and old-style tag_only
#12512
Conversation
Sent feedback via Slack thread. Summary: old |
i downloaded the binary with the 3 additional commits from 18 jan 12:15...still broken for me...i will update the ticket. |
dfb16a4
to
a4b3a8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof this took a while, but I only have a question about all the commented out new code?
4daca8a
to
ea75c62
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving it to you to merge, thanks for the fix!
resolves #11778
In PR #11019 a new style of handling dynamic tags was introduced, able to handle more complex tagging rules (e.g. by matching an interface key). However, the conversion/back-porting of the previous behavior will only work for a small subset of devices that expose an
interface
key and thus broke previous users (as described in #11778).This PR reworks the tag-handling to be able to support both behaviors adding an
match
option. The plugin intelligently chooses the value if not given to be backward-compatible to both current use-cases.However, this logic required a larger refactoring of the plugin. While code is more understandable now IMO, the volume of the change is considerable...