Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.upsd): always convert to float #12516

Merged
merged 8 commits into from
Jan 26, 2023
Merged

fix(inputs.upsd): always convert to float #12516

merged 8 commits into from
Jan 26, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jan 17, 2023

There are a number of values that can show up as a float or an int. This ensures the floats are always floats to avoid having some devices report as an int and others as a float and conflict in influxdb.

Additionally, if we fail to convert in either the float or string case, then skip trying to add the field.

fixes: #12501

@powersj
fix(inputs.upsd): always convert to float
a89e597 
There are a number of values that can show up as a float or an int. This
ensures the floats are always floats to avoid having some devices report
as an int and others as a float and conflict in influxdb.

Additionally, if we fail to convert in either the float or string case,
then skip trying to add the field.

fixes: influxdata#12501
@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 17, 2023
@powersj powersj mentioned this pull request Jan 17, 2023
Closed
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 17, 2023
srebhan
srebhan reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good code-wise, but shouldn't we add a flag to switch between previous behavior and the new one? We could name it native_values and discuss if the new or old behavior should be the default (I vote for the old one)...

@powersj
Copy link
Contributor Author

powersj commented Jan 18, 2023

shouldn't we add a flag to switch between previous behavior and the new one?

unfortunately, yes. I do not like the situation it puts new users in where we know they could start to run into issue and have to turn on an option to get consistent data and then go fix their database.

@srebhan
Copy link
Contributor

srebhan commented Jan 20, 2023

I'm not against setting the flag to a sensible default enabling the new behavior. We can still list this as a breaking change in the Changelog.

@powersj powersj mentioned this pull request Jan 24, 2023
Closed
srebhan
srebhan reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One cosmetic suggestion though...

plugins/inputs/upsd/upsd.go Outdated Show resolved Hide resolved
powersj and others added 2 commits January 25, 2023 07:40
@powersj @srebhan
Update plugins/inputs/upsd/upsd.go
a2ea6a5 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@powersj
skip nil values
0cc97aa
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

srebhan
srebhan approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@srebhan srebhan merged commit 4b445f6 into influxdata:master Jan 26, 2023
srebhan pushed a commit that referenced this pull request Jan 30, 2023
@powersj
fix(inputs.upsd): Always convert to float (#12516)
725475a 
(cherry picked from commit 4b445f6)
@sabey
Copy link

sabey commented Apr 5, 2024

this still persists in the latest release Telegraf 1.30.1 for nominal_battery_voltage

2024-04-05T10:15:26Z E! [outputs.influxdb] E! [outputs.influxdb] Failed to write metric (will be dropped: 400 Bad Request): partial write: field type conflict: input field "nominal_battery_voltage" on measurement "upsd" is type integer, already exists as type float dropped=1

@srebhan
Copy link
Contributor

srebhan commented Apr 10, 2024

@sabey please open a new issue instead of commenting on an old PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UPSD issue - load_percent presented as both int and float blocks writes from one group
3 participants
@powersj @srebhan @sabey