Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.exec): Restore pre-v1.21 behavior for CSV data_format #12533

Merged
merged 11 commits into from
Jan 26, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Jan 23, 2023

resolves #12022

This PR restores the CSV parsing behavior for inputs.exec to the one experienced in pre-v1.21 versions. In v1.21 the behavior suddenly changed to not resetting the parser anymore. While this is acceptable and expected for other plugins (see additional unit-tests), it is less helpful for exec as the commands run usually output a complete CSV instead of incremental data-lines.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jan 23, 2023
@srebhan srebhan changed the title fix(inputs.execparsers.csv): issue 12022 fix(inputs.exec): Restore v1.20.x behavior for CSV data_format Jan 23, 2023
@srebhan srebhan changed the title fix(inputs.exec): Restore v1.20.x behavior for CSV data_format fix(inputs.exec): Restore pre-v1.21 behavior for CSV data_format Jan 23, 2023
@srebhan srebhan added area/exec plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins area/csv csv parser/serialiser related plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins labels Jan 23, 2023
@telegraf-tiger
Copy link
Contributor

@powersj powersj merged commit eb03bb5 into influxdata:master Jan 26, 2023
srebhan added a commit that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/csv csv parser/serialiser related area/exec fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.exec with data_format = "csv"
2 participants