Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.prometheus): Set the timeout for slow running API endpoints correctly #12559

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix(inputs.prometheus): Set the timeout for slow running API endpoints correctly #12559

merged 1 commit into from
Jan 30, 2023

Conversation

ZPascal
Copy link
Contributor

@ZPascal ZPascal commented Jan 27, 2023

resolves #12485

Description:
The issue was related to a missed timeout configuration inside http client to establish a connection to an slow responsed Promtheus endpoint.

@ZPascal ZPascal force-pushed the ISSUE12485-fix-prometheus-timeout branch from 5412af9 to 3a4836c Compare January 27, 2023 10:49
@ZPascal ZPascal changed the title bug: Set the timeout for slow running API endpoints correctly fix: Set the timeout for slow running API endpoints correctly Jan 27, 2023
@ZPascal ZPascal force-pushed the ISSUE12485-fix-prometheus-timeout branch from 3a4836c to 746fb72 Compare January 27, 2023 11:09
powersj
powersj reviewed Jan 27, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down and putting up a PR! Two comments inline

plugins/inputs/prometheus/prometheus_test.go Show resolved Hide resolved
plugins/inputs/prometheus/prometheus.go Outdated Show resolved Hide resolved
@powersj powersj added the waiting for response waiting for response from contributor label Jan 27, 2023
@ZPascal ZPascal force-pushed the ISSUE12485-fix-prometheus-timeout branch from c9fdcae to 4b1b74f Compare January 30, 2023 11:41
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

powersj
powersj approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@powersj powersj added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. and removed waiting for response waiting for response from contributor labels Jan 30, 2023
@ZPascal ZPascal mentioned this pull request Jan 30, 2023
Closed
@Hipska Hipska mentioned this pull request Jan 30, 2023
Closed
srebhan
srebhan approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the nice fix @ZPascal!

@srebhan srebhan changed the title fix: Set the timeout for slow running API endpoints correctly fix(inputs.prometheus): Set the timeout for slow running API endpoints correctly Jan 30, 2023
@srebhan srebhan added area/prometheus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 30, 2023
@srebhan srebhan merged commit dc9eb02 into influxdata:master Jan 30, 2023
@ZPascal ZPascal deleted the ISSUE12485-fix-prometheus-timeout branch January 30, 2023 14:58
srebhan pushed a commit that referenced this pull request Jan 30, 2023
@ZPascal
fix(inputs.prometheus): Set the timeout for slow running API endpoint…
b82f209 
…s correctly (#12559)

(cherry picked from commit dc9eb02)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/prometheus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[inputs.prometheus] Error in plugin: Client.Timeout exceeded while awaiting headers)
3 participants
@ZPascal @powersj @srebhan