Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(outputs.prometheus_client): expire with ticker, not add/collect #12560

Merged
merged 1 commit into from
Jan 31, 2023
Merged

fix(outputs.prometheus_client): expire with ticker, not add/collect #12560

merged 1 commit into from
Jan 31, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jan 27, 2023

The current method of expiration is to check at every adding or collecting of metrics. However, this blocks and slows a lot of things down. Instead, create a ticker that will launch the expiration process when we actually need to expire.

fixes: #12481

@powersj
fix(outputs.prometheus_client): expire with ticker, not add/collect
3be421c 
The current method of expiration is to check at every adding or
collecting of metrics. However, this blocks and slows a lot of things
down. Instead, create a ticker that will launch the expiration process
when we actually need to expire.

fixes: influxdata#12481
@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Jan 27, 2023
@powersj powersj mentioned this pull request Jan 27, 2023
Closed
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 30, 2023
srebhan
srebhan approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the fix @powersj!

@srebhan srebhan merged commit b20e490 into influxdata:master Jan 31, 2023
powersj added a commit that referenced this pull request Feb 13, 2023
@powersj
fix(outputs.prometheus_client): Expire with ticker, not add/collect (#…
67b541c 
…12560)

(cherry picked from commit b20e490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrieving Metrics from prometheus_client output plugin takes very long since Telegraf version 1.24.4
2 participants
@powersj @srebhan