fix(inputs.mysql): Avoid side-effects for TLS between plugin instances #12576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the plugin registers its TLS configuration as key
"custom"
to the MySQL driver. However, this registration is global to the driver package and therefor potential side-effects between multiple plugin instances arise if those instances register different TLS configurations.This PR fixes the issue by replacing the
"custom"
key with a unique key while keeping the user-facing configuration the same. Furthermore, we move the initialization to theInit()
function in order to save some cycles and avoid the necessity to frequently create random registrations.