feat: always disable cgo support (static builds) #12600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
the
feat
powersj
force-pushed
the
feat/static-builds
branch
from
7b7182b
to
9cad4a6
Compare
This ensures that cgo is always disabled with builds using the Makefile. Telegraf does not support importing C libraries or depending on any of them in the first place. This is to ensure cross-platform and cross-OS support. Our official builds for Windows, macOS, and BSD are cross-compiled. In these cases, cgo is already disabled. This primarily affects the linux builds. This will enable us to deliver the much requested arm64 docker images for Alpine. In influxdata#8278, a check for the glibc version was added after a user noticed the binary was depending on newer versions of glibc. This removes those checks as static builds will not need these checks. Finally, this removes the no longer necessary static specific build.
powersj
force-pushed
the
feat/static-builds
branch
from
9cad4a6
to
c6976f7
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
jdstrand
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
I'll let @srebhan comment on the specifics, but I looked over the PR and it looks reasonable. I'm a fan of disabling CGO unless it is absolutely required and this should improve portability and maintenance in general.
Fyi, in an Ubuntu 20.04 container, I ran make and CGO is disabled:
$ make
...
CGO_ENABLED=0 go build -ldflags " -X github.com/influxdata/telegraf/internal.Commit=c6976f77 -X github.com/influxdata/telegraf/internal.Branch=HEAD -X github.com/influxdata/telegraf/internal.Version=1.26.0-c6976f77" ./cmd/telegraf
$ go version -m ./telegraf | grep CGO_ENABLED
build CGO_ENABLED=0
# compare to current deb
$ go version -m ./usr/bin/telegraf |grep CGO_ENABLED
build CGO_ENABLED=1
srebhan
approved these changes
Feb 3, 2023
powersj
added a commit
to powersj/telegraf
that referenced
this pull request
Mar 13, 2023
This should not have been removed and not sure why it was part of a previous PR. fixes: influxdata#12600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that cgo is always disabled with builds using the Makefile. Telegraf does not support importing C libraries or depending on any of them in the first place. This is to ensure cross-platform and cross-OS support.
Our official builds for Windows, macOS, and BSD are cross-compiled. In these cases, cgo is already disabled. This primarily affects the linux builds. This will enable us to deliver the much requested arm64 docker images for Alpine.
In #8278, a check for the glibc version was added after a user noticed the binary was depending on newer versions of glibc. This removes those checks as static builds will not need these checks.
Finally, this removes the no longer necessary static specific build.
fixes: #8997