Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agent): only read the config once #12607

Merged
merged 2 commits into from
Feb 6, 2023
Merged

fix(agent): only read the config once #12607

merged 2 commits into from
Feb 6, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Feb 2, 2023

Pass the contents of the config from the reloadLoop into runAgent. Currently the behavior is to go through and read the config twice.

fixes: #12606

@powersj
fix(agent): only read the config once
6d22b79 
Pass the contents of the config from the reloadLoop into runAgent.
Currently the behavior is to go through and read the config twice.

fixes: influxdata#12606
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Feb 2, 2023
@powersj
Copy link
Contributor Author

powersj commented Feb 2, 2023

I need to test this further, but wanted to toss this up now.

@powersj powersj mentioned this pull request Feb 2, 2023
Closed
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Feb 2, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 2.20 % for linux amd64 (new size: 165.3 MB, nightly size 161.7 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 3, 2023
srebhan
srebhan approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @powersj!

@srebhan srebhan merged commit 31a87df into influxdata:master Feb 6, 2023
powersj added a commit that referenced this pull request Feb 13, 2023
@powersj
fix(agent): Only read the config once (#12607)
adb7262 
(cherry picked from commit 31a87df)
@gazpachoking gazpachoking mentioned this pull request Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On start, the config is loaded twice
2 participants
@powersj @srebhan