feat(agent): add /etc/telegraf/telegraf.d to default config locations #12608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
the
feat
This will add /etc/telegraf/telegraf.d to the list of default configuration locations to load from. Currently, users need to specify an empty /etc/telegraf/telegraf.conf file and specify they want to include the configuraiton directory outside of the RPM and DEB. A common use case is for Docker where users want to upload an entire directory of configurations and run telegraf. Right now they have to add a custom launch command, when in reality we should include this directory by default. This also means that the --config option can be omitted from the CLI if a user is only using --config-directory. fixes: influxdata#5656 fixes: influxdata#5571
powersj
force-pushed
the
feat/read-conf-dir
branch
from
6f03bd9
to
30561c4
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
powersj
added
the
ready for final review
srebhan
approved these changes
Feb 7, 2023
|
Also fixes influxdata/influxdata-docker#568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add /etc/telegraf/telegraf.d to the list of default
configuration locations to load from. A common use case is for
Docker where users want to upload an entire directory of
configurations and run telegraf. Right now they have to add
a custom launch command, when in reality we should include this
directory by default.
This also means that the --config option can be omitted from the CLI
if a user is only using --config-directory. Currently, users need to specify
an empty /etc/telegraf/telegraf.conf file and specify they want to
include only a configuration directory.
fixes: #5656
fixes: #5571