-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rename the Prometheus Input Plugin Timeout variable #12626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to quickly put a PR.
I am happy to see the new option, but instead of outright removing the old option, we want to deprecate the option. This way users get a warning before we outright remove.
@powersj You're right. That makes sense. I'll handle it later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update and tests! Just two suggestions to make the new option show up first in the config.
Co-authored-by: Joshua Powers <powersj@fastmail.com>
Co-authored-by: Joshua Powers <powersj@fastmail.com>
@powersj Sure, it's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @ZPascal. I do have two small comments...
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @ZPascal!
(cherry picked from commit aa0b9d7)
Rename the Timeout Prometheus Input Plugin variable inside the configuration and the code to parse the corresponding value directly
Be aware it's a breaking change for older versions and should be merged into the next major version.
resolves #12565
Fix the corresponding case and renames the variable as already discussed inside #12565