-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.x509_cert): Fix Windows path handling #12629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your attention on this one. I am going to leave it to you to merge it, in case you want to wait for PR feedback. Otherwise, feel free to land it before the bug fix next week.
If (AFAIK if you url.Parse |
Both should be supported now on Windows. |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
So everything working, I tested these
|
(cherry picked from commit ff89b77)
resolves #10580
This PR fixes the handling of Windows paths by directly creating the URL instead of using a fragile indirection parsing a hand-crafted string.