Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.cisco_telemetry_mdt): check subfield sizes to avoid panics #12637

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Feb 6, 2023

fixes: #12635

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 6, 2023
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 7, 2023
@powersj powersj marked this pull request as ready for review February 7, 2023 14:19
@powersj powersj changed the title fix(inputs.cisco_telemetry_mdt): check subfield sizes fix(inputs.cisco_telemetry_mdt): check subfield sizes to avoid panics Feb 7, 2023
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @powersj, I think you are radically drop out early while I'm not sure if in cases were there are no subfield-fields the subfield might contain a sensible value... Are you sure this does not break other (maybe valid) use cases?

plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go Outdated Show resolved Hide resolved
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go Outdated Show resolved Hide resolved
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue @powersj!

@srebhan
Copy link
Contributor

srebhan commented Feb 8, 2023

Assigning it back to you @powersj in case you want to wait for testing!

@srebhan srebhan assigned powersj and unassigned srebhan Feb 8, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Feb 8, 2023

@anpedro
Copy link

anpedro commented Feb 8, 2023

tested with latest fixes, it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
3 participants