Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.x509_cert): Add tag for certificate type-classification #12656

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Feb 9, 2023

resolves #7012

This PR classifies the type of a certificate into leaf, intermediate and root certificates. The information is added as type tag.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 9, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 9, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the helpful inline comments. Do we have test coverage for these new paths already?

@srebhan
Copy link
Contributor Author

srebhan commented Feb 10, 2023

@powersj the problem with tests using a certificate from file is that those might expire... Let me think about a way...

@powersj
Copy link
Contributor

powersj commented Feb 10, 2023

the problem with tests using a certificate from file is that those might expire...

Right, we do have some have some test certs in testutil/pki. I am cool with adding some certs there as long as you document how they are created.

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test question. As soon as tests pass, ship it

plugins/inputs/x509_cert/x509_cert_test.go Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan merged commit d1d9737 into influxdata:master Feb 22, 2023
@srebhan srebhan deleted the x509_issue_7012 branch February 22, 2023 12:39
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x509_cert plugin - add tag to identify cert as intermediate or end
2 participants