-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.x509_cert): Add tag for certificate type-classification #12656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the helpful inline comments. Do we have test coverage for these new paths already?
@powersj the problem with tests using a certificate from file is that those might expire... Let me think about a way... |
Right, we do have some have some test certs in |
5ed4689
to
687a83e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One test question. As soon as tests pass, ship it
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
resolves #7012
This PR classifies the type of a certificate into leaf, intermediate and root certificates. The information is added as
type
tag.