fix(inputs.cloudwatch): enable custom endpoint support #12657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
fix
powersj
added
the
ready for final review
srebhan
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Looks good to me. I wonder if we should use the EndpointResolverFromURL function instead of completely customizing the endpoint-resolver, but the present code also works for me. So either change or merge as is @powersj, both is fine with me.
If a user specifis a specific region and endpoint, then the cloudwatch client needs to be set up to use those two values and override the default values that are provided. fixes: influxdata#12653
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
powersj
added a commit
that referenced
this pull request
Feb 13, 2023
(cherry picked from commit f206c27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user specifies a specific region and endpoint, then the cloudwatch client needs to be set up to use those two values and override the default values that are provided.
fixes: #12653