Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(processors.unpivot): new mode to create new metrics #12659

Merged
merged 3 commits into from
Feb 15, 2023
Merged

feat(processors.unpivot): new mode to create new metrics #12659

merged 3 commits into from
Feb 15, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Feb 9, 2023

Add mode settings to pivot processor to allow a user to create new metrics based on field names. The previous and default behavior would use the same metric name, but add the field as a tag.

fixes: #12652

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/processor labels Feb 9, 2023
@powersj powersj mentioned this pull request Feb 9, 2023
Closed
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 13, 2023
@powersj powersj marked this pull request as ready for review February 13, 2023 14:05
srebhan
srebhan reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, I only do have one comment regarding the option. I'm not sure if the naming/usage is intuitive...

plugins/processors/unpivot/sample.conf Outdated Show resolved Hide resolved
@powersj
feat(processors.unpivot): new mode to create new metrics
ab4368c 
Add mode settings to pivot processor to allow a user to create new
metrics based on field names. The previous and default behavior would
use the same metric name, but add the field as a tag.

fixes: influxdata#12652
@powersj
rename metric_mode to use_fieldname_as
90ab6c3
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this feature @powersj!

@srebhan srebhan merged commit ecfd367 into influxdata:master Feb 15, 2023
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/processor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.26.0
Development

Successfully merging this pull request may close these issues.

processor: unpivot fields into new measurements
2 participants
@powersj @srebhan