Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for tcp endpoints in haproxy plugin #12680

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

jsnjack
Copy link
Contributor

@jsnjack jsnjack commented Feb 14, 2023

Required for all PRs

resolves #12672

  • Added support for tcp endpoints in haproxy input plugin. For example, if haproxy is configured to expose stats endpoint with stats socket ipv4@127.0.0.1:9999 level admin, the plugin will be able to communicate with it with servers = ["tcp://127.0.0.1:9999"] configuration

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Feb 14, 2023
@powersj
Copy link
Contributor

powersj commented Feb 15, 2023

Could not find a usable config.yml, you may have revoked the CircleCI OAuth app.

This error from CircleCI shows up when you have an account with CircleCI and either you are logged out if you use a username/password or if you have a GitHub OAuth login, need to disconnect and reconnect your account.

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to put up a PR. I have one small nit and a doc change that I'd like to see. Feel free to wordsmith or update that as you see fit.

Thanks!

plugins/inputs/haproxy/haproxy_test.go Outdated Show resolved Hide resolved
plugins/inputs/haproxy/sample.conf Outdated Show resolved Hide resolved
plugins/inputs/haproxy/sample.conf Outdated Show resolved Hide resolved
plugins/inputs/haproxy/sample.conf Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this up!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 17, 2023
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution @jsnjack!

@srebhan srebhan added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Feb 17, 2023
@srebhan srebhan merged commit da675d4 into influxdata:master Feb 17, 2023
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support stats socket with tcp address in haproxy input plugin
3 participants