-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for tcp endpoints in haproxy plugin #12680
Conversation
This error from CircleCI shows up when you have an account with CircleCI and either you are logged out if you use a username/password or if you have a GitHub OAuth login, need to disconnect and reconnect your account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to put up a PR. I have one small nit and a doc change that I'd like to see. Feel free to wordsmith or update that as you see fit.
Thanks!
Co-authored-by: Joshua Powers <powersj@fastmail.com>
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your contribution @jsnjack!
Required for all PRs
resolves #12672
stats socket ipv4@127.0.0.1:9999 level admin
, the plugin will be able to communicate with it withservers = ["tcp://127.0.0.1:9999"]
configuration