fix(agent): reload config on config update #12721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a recent change we moved to loading the config only once during the initial load of telegraf. This saves time and is more efficient from reading files on disk, however, it ignored the fact that we need to reload the config if someone is watching a config. This reload occurs in runAgent, where the second reading was always taking place. This updates the logic, so that we only re-read the configs in runAgent if we are calling it a second time from the reload loop. fixes: influxdata#12718
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
powersj
added
the
ready for final review
powersj
added a commit
that referenced
this pull request
Feb 27, 2023
(cherry picked from commit 95877a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent change we moved to loading the config only once during the initial load of telegraf. This saves time and is more efficient from reading files on disk, however, it ignored the fact that we need to reload the config if someone is watching a config. This reload occurs in runAgent, where the second reading was always taking place.
This updates the logic, so that we only re-read the configs in runAgent if we are calling it a second time from the reload loop.
fixes: #12718