Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.lvm): Allow to specify path to binaries in config file #12725

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

dynek
Copy link
Contributor

@dynek dynek commented Feb 22, 2023

Fixes this problem mentioned by @rafaelreis-r to @powersj.

I basically followed what is done in other plugins when it comes to make it possible for user to specify path to binary files.
In this specific situation, I need to be able to modify path for lvs, vgs and lvs as they are located in /sbin/ on my Linux system (Debian Bullseye) rather than /usr/sbin/ like it is currently hard-coded.

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 22, 2023
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dynek for your contribution! Only two small comments from my side. Can you please take a look!?

plugins/inputs/lvm/sample.conf Outdated Show resolved Hide resolved
plugins/inputs/lvm/lvm.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Feb 23, 2023
@Hipska Hipska added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 23, 2023
@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution @dynek!

@srebhan srebhan assigned powersj and unassigned srebhan Feb 24, 2023
@powersj powersj merged commit e51b381 into influxdata:master Feb 24, 2023
powersj pushed a commit that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants