-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.lvm): Allow to specify path to binaries in config file #12725
Conversation
7c08ea9
to
3770df9
Compare
3770df9
to
7210add
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dynek for your contribution! Only two small comments from my side. Can you please take a look!?
e6ebbb0
to
9c2f813
Compare
9c2f813
to
a24a4fa
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your contribution @dynek!
(cherry picked from commit e51b381)
Fixes this problem mentioned by @rafaelreis-r to @powersj.
I basically followed what is done in other plugins when it comes to make it possible for user to specify path to binary files.
In this specific situation, I need to be able to modify path for
lvs
,vgs
andlvs
as they are located in/sbin/
on my Linux system (Debian Bullseye) rather than/usr/sbin/
like it is currently hard-coded.