Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common.tls): Add enable flag #12727

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Feb 23, 2023

Currently, TLS is disabled if no tls_* option is specified. This prevents users from using e.g. TLS on TCP connections using the system defaults. This PR adds a tls_enable flag to the common TLS client configuration. When not given, the behavior of Telegraf is unchanged. However, if explicitly set to false all TLS settings are ignored and TLS is disabled. When set to true, TLS is enforced even if no other TLS option is given, allowing for using the system's default settings.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Feb 23, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 23, 2023
@powersj
Copy link
Contributor

powersj commented Feb 23, 2023

Should we include an update to https://github.com/influxdata/telegraf/blob/master/docs/TLS.md

@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@powersj powersj merged commit 9e519de into influxdata:master Feb 27, 2023
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants