fix(agent): Only rotate log on SIGHUP if needed #12740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code will rotate a log on a SIGHUP. Whether the log needs to be rotate or not. There are checks at start up and at each write if a log needs to be rotated. Meaning that we should not be forcing a rotate at close, and instead check to verify the conditions are even met first. fixes: influxdata#12709
powersj
added
the
ready for final review
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
|
thanks a lot for change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code will rotate a log on a SIGHUP. Whether the log needs to be rotated or not. There are checks at start-up and at each write if a log needs to be rotated. Meaning that we should not be forcing a rotation at close, and instead check to verify the conditions are even met first.
fixes: #12709