Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(processors.converter): convert tag or field as metric timestamp #12767

Merged
merged 4 commits into from
Mar 9, 2023
Merged

feat(processors.converter): convert tag or field as metric timestamp #12767

merged 4 commits into from
Mar 9, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Feb 28, 2023

This adds the timestamp and timestamp_format options to the converter processor. This allows users to take a tag or field and make it the metric timestamp. It uses the same format parsing code that is used throughout Telegraf.

fixes: #12746

@powersj
feat(processors.converter): convert tag or field as metric timestamp
5d7613c 
This adds the timestamp and timestamp_format options to the converter
processor. This allows users to take a tag or field and make it the
metric timestamp. It uses the same format parsing code that is used
throughout Telegraf.

fixes: influxdata#12746
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/processor labels Feb 28, 2023
@powersj powersj mentioned this pull request Feb 28, 2023
Closed
Hipska
Hipska suggested changes Mar 2, 2023
View reviewed changes
plugins/processors/converter/converter.go Outdated Show resolved Hide resolved
plugins/processors/converter/sample.conf Outdated Show resolved Hide resolved
plugins/processors/converter/sample.conf Outdated Show resolved Hide resolved
@powersj
Changes:
47eeb24 
* convert timestmap to string slice
* add additional test cases
* note that measurement and timestamp order is not guaranteed
@powersj powersj marked this pull request as ready for review March 9, 2023 15:04
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 9, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Mar 9, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for taking care of this @powersj!

@srebhan srebhan merged commit 736f6ac into influxdata:master Mar 9, 2023
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hipska Hipska Hipska approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/processor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.26.0
Development

Successfully merging this pull request may close these issues.

processors.converter - convert time
3 participants
@powersj @Hipska @srebhan