Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.prometheus): use namespace annotations to filter pods to be scraped #12777

Merged
merged 5 commits into from
Mar 7, 2023

Conversation

redbaron
Copy link
Contributor

@redbaron redbaron commented Mar 2, 2023

resolves #12776

@redbaron redbaron force-pushed the namespace-labels branch 2 times, most recently from 9c63afb to fd672e5 Compare March 2, 2023 13:17
@redbaron redbaron changed the title inputs.prometheus: use namespace annotations to filter pods to be scraped feat(inputs.prometheus): use namespace annotations to filter pods to be scraped Mar 2, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good, thanks for the clean up as well. Two comments on the sample conf + make docs afterwards

plugins/inputs/prometheus/sample.conf Outdated Show resolved Hide resolved
plugins/inputs/prometheus/sample.conf Outdated Show resolved Hide resolved
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 3, 2023
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution @redbaron!

@srebhan
Copy link
Contributor

srebhan commented Mar 6, 2023

@redbaron can you please fix the merge conflict!?

@redbaron
Copy link
Contributor Author

redbaron commented Mar 6, 2023

@srebhan , done

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Mar 6, 2023

Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @redbaron!

@srebhan srebhan merged commit ee68253 into influxdata:master Mar 7, 2023
@redbaron redbaron deleted the namespace-labels branch March 7, 2023 09:51
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow input.prometheus to select pods based on namespace annotation
3 participants