Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.statsd): On close, verify listener is not nil #12778

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Mar 2, 2023

If we attempt to close a listener that is nil, telegraf will panic. This
can occur if the port is already in use and we never start the listener.
For example, in test mode.

fixes: #12744

If we attempt to close a listener that is nil, telegraf will panic.

fixes: influxdata#12744
@telegraf-tiger telegraf-tiger bot added area/statsd fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 2, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Mar 2, 2023

Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Feel free to merge it as soon as you think it's ready.

@powersj powersj merged commit dfe8b43 into influxdata:master Mar 3, 2023
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/statsd fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: from statsd during --test
2 participants