fix(agent): Allow gracefull shutdown on interrupt (e.g. Ctrl-C) #12781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v1.25.0 we introduced secret-stores (PR #11232) and with this added a call to
memguard.CatchInterrupt()
however, this created a race-condition with the usual signal handling in telegraf where almost alwaysmemguard
was successful in callingos.Exit
before the agent finished shutting down the plugins etc.This PR removes the call to
memguard.CatchInterrupt()
. This is safe as we handle interrupts already and use thedefer memguard.Purge()
statement to safely erase all secrets.