Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.modbus): Add RS485 specific config options #12786

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Mar 3, 2023

resolves #12784

This PR exposes RS485 specific configuration options.

@telegraf-tiger telegraf-tiger bot added area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 3, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 3, 2023
@powersj powersj assigned srebhan and unassigned powersj Mar 3, 2023
@powersj
Copy link
Contributor

powersj commented Mar 3, 2023

Approved, I'll leave it to you to merge if you want to wait for the user to confirm

@srebhan srebhan requested a review from powersj March 7, 2023 14:50
@srebhan
Copy link
Contributor Author

srebhan commented Mar 7, 2023

@powersj can you please take a look again as I've changed the code a bit. This code seems to work according to the reporter of the issue...

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! Glad we got someone to try it out!

@powersj powersj merged commit 0a0cbc2 into influxdata:master Mar 7, 2023
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow RS485 mode in MODBUS Plugin
2 participants