Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.cgroup): Added support for cpu.stat #12798

Merged
merged 1 commit into from
Mar 7, 2023
Merged

feat(inputs.cgroup): Added support for cpu.stat #12798

merged 1 commit into from
Mar 7, 2023

Conversation

an0nfunc
Copy link
Contributor

@an0nfunc an0nfunc commented Mar 4, 2023 •
edited

Required for all PRs

cgroup v2 mounted with hierarchy=unified do not provide cpuacct [0], so this PR adds . to valid characters in keys for key-value pairs, which in turn fixes parsing cpu.stat, making it possible to measure cpu usage on v2 cgroup mounts with hierarchy=unified (default since systemd v243).

[0] systemd/systemd#13477

@an0nfunc
feat(inputs.cgroup): Added support for cpu.stat
6419af1 
Since cgroup v2 unified does not provide cpuacct, this provides a possibility to
measure cpu usage on v2 cgroup mounts with hierarchy=unified, which is
default since systemd v243.
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 4, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Mar 4, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

powersj
powersj approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 6, 2023
srebhan
srebhan approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature @an0nfunc! Thanks for your contribution!

@srebhan srebhan merged commit 69d9a43 into influxdata:master Mar 7, 2023
@an0nfunc an0nfunc deleted the feat-cgroup-cpu.stat branch March 7, 2023 13:39
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.26.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@an0nfunc @powersj @srebhan