Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.modbus): Allow to convert coil and discrete registers to boolean #12825

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Mar 9, 2023

resolves #9284

This PR adds the ability to specify an output-datatype for coil and discrete registers. You can choose between UINT16 (default) and BOOL. The former is used currently and will be used as default when the datatype is omitted. The latter will case all non-zero registers to be emitted as true or false otherwise.

@telegraf-tiger telegraf-tiger bot added area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 9, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 9, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Mar 9, 2023

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@powersj powersj assigned srebhan and unassigned powersj Mar 10, 2023
@srebhan srebhan merged commit 2006086 into influxdata:master Mar 13, 2023
@srebhan srebhan deleted the modbus_issue_9284 branch March 13, 2023 11:18
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
@srebhan srebhan mentioned this pull request Jun 27, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[inputs.modbus] Handle coils and discrete_inputs as booleans
2 participants